Avoid deprecated / superseded arguments from openxlsx2 #320
+89
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivroy
changed the title
Merged
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 70.03% 69.70% -0.34%
==========================================
Files 44 44
Lines 2056 2043 -13
==========================================
- Hits 1440 1424 -16
- Misses 616 619 +3 ☔ View full report in Codecov by Sentry. |
IndrajeetPatil
approved these changes
Sep 12, 2024
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In openxlsx2 0.8, arguments were changed to snake case
https://janmarvin.github.io/openxlsx2/news/index.html#openxlsx2-08
rowsandcolsare also deprecated in favour of dims (the cell range)See details in https://janmarvin.github.io/openxlsx2/news/index.html#breaking-changes-0-8.
The legacy arguments still work, but they be deprecated in a future openxlsx2 version.
I updated the example in the discussion (JanMarvin/openxlsx2#286)